IWETHEY v. 0.3.0 | TODO
1,095 registered users | 0 active users | 1 LpH | Statistics
Login | Create New User
IWETHEY Banner

Welcome to IWETHEY!

IWETHEY Home / IWETHEY Board / Theory and Practice of Programming Forum / And I would point out that...
Post #231,668
by ben_tilly
10/31/05 11:30:32 AM
Reply
New And I would point out that...
you really want to check whether mkdir succeeds. Perhaps you don't have permissions to the directory it is in? Perhaps there is a file there of that name?

This is somewhat mitigated by the fact that he shortly afterwards tries to create a file in that directory and checks $! there. So he will notice the error. But good habits are good habits.

Cheers,
Ben
I have come to believe that idealism without discipline is a quick road to disaster, while discipline without idealism is pointless. -- Aaron Ward (my brother)
Post #231,711
by admin
Picture of admin
10/31/05 2:21:34 PM
Reply
New How to do that...
mkdir($foo) or die "Unable to make directory!" unless -d $foo; ? Does that need parentheses anywhere?

Note that I was just demonstrating using -d, and not actually putting any thought into the answer whatsoever. ;-)
Regards,

-scott anderson

"Welcome to Rivendell, Mr. Anderson..."
Post #231,719
by ben_tilly
10/31/05 3:07:35 PM
Reply
New That works but...
There is a reason why Perl does not let you nest if's directly. It is confusing. Perl allows enough cryptic things, but even Larry drew the line at that one.

Create a block for that. They're cheap.
\nunless (-d $foo) {\n  mkdir($foo) or die "Cannot mkdir '$foo': $!";\n}\n


Cheers,
Ben
I have come to believe that idealism without discipline is a quick road to disaster, while discipline without idealism is pointless. -- Aaron Ward (my brother)
Post #231,735
by admin
Picture of admin
10/31/05 4:03:49 PM
Reply
New Ah, good. Thanks.
Regards,

-scott anderson

"Welcome to Rivendell, Mr. Anderson..."
     Checking for the existence of a directory in Perl - (pwhysall) - (53) - Oct. 31, 2005, 08:58:57 AM EST
         I use: - (admin) - (52) - Oct. 31, 2005, 09:19:47 AM EST
             Context - (pwhysall) - (51) - Oct. 31, 2005, 09:30:44 AM EST
                 Re: Context - (admin) - (5) - Oct. 31, 2005, 10:18:59 AM EST
                     Moochos grassy arse. -NT - (pwhysall) - Oct. 31, 2005, 10:26:40 AM EST
                     And I would point out that... - (ben_tilly) - (3) - Oct. 31, 2005, 11:30:32 AM EST
                         How to do that... - (admin) - (2) - Oct. 31, 2005, 02:21:34 PM EST
                             That works but... - (ben_tilly) - (1) - Oct. 31, 2005, 03:07:35 PM EST
                                 Ah, good. Thanks. -NT - (admin) - Oct. 31, 2005, 04:03:49 PM EST
                 Minor points - (ben_tilly) - (44) - Oct. 31, 2005, 11:50:58 AM EST
                     Re: Minor points - (pwhysall) - Oct. 31, 2005, 01:02:42 PM EST
                     Slightly OT: on brace style: - (admin) - (42) - Oct. 31, 2005, 02:25:54 PM EST
                         That's what I've been doing, but I'm a noob. - (Another Scott) - Oct. 31, 2005, 02:28:40 PM EST
                         No way, this is the shizzit - (jake123) - Oct. 31, 2005, 03:10:18 PM EST
                         Yes, that is the correct form - (tuberculosis) - Oct. 31, 2005, 03:29:44 PM EST
                         I've heard arguments for and against that - (ben_tilly) - (38) - Oct. 31, 2005, 03:37:28 PM EST
                             The arguments are simple - (tuberculosis) - (13) - Oct. 31, 2005, 03:40:07 PM EST
                                 Ah, an open mind. - (Yendor) - (1) - Oct. 31, 2005, 03:52:54 PM EST
                                     Yeah, but he's right. - (pwhysall) - Oct. 31, 2005, 03:56:51 PM EST
                                 Yes, we know you're strongly imprinted - (ben_tilly) - (10) - Oct. 31, 2005, 04:07:50 PM EST
                                     I'm interested in research too - (tuberculosis) - (4) - Oct. 31, 2005, 05:08:27 PM EST
                                         so K&R is wrong? Heretic BURN HIM! -NT - (boxley) - (1) - Oct. 31, 2005, 05:22:53 PM EST
                                             :-\ufffd :-\ufffd :-\ufffd :-\ufffd -NT - (jb4) - Oct. 31, 2005, 10:45:07 PM EST
                                         There's a lot of stuff at scholar.google.com - (Another Scott) - Oct. 31, 2005, 05:28:23 PM EST
                                         I think it depends on your visual habits. - (static) - Oct. 31, 2005, 09:48:21 PM EST
                                     Sidenote - (Simon_Jester) - (4) - Nov. 1, 2005, 09:29:21 AM EST
                                         Automate that Jalopy - (Yendor) - (2) - Nov. 1, 2005, 09:37:17 AM EST
                                             That's okay... - (Simon_Jester) - (1) - Nov. 1, 2005, 09:44:25 AM EST
                                                 np - (Yendor) - Nov. 1, 2005, 09:59:47 AM EST
                                         Yes, that's a PBP recommend :-) - (ben_tilly) - Nov. 1, 2005, 11:14:00 AM EST
                             I'm seeing comments that "Code Complete" addresses that - (Another Scott) - (15) - Oct. 31, 2005, 03:59:22 PM EST
                                 Where? - (ben_tilly) - (14) - Oct. 31, 2005, 04:06:37 PM EST
                                     CC2, pp 740-743 -NT - (Yendor) - (3) - Oct. 31, 2005, 04:13:13 PM EST
                                         I should finish reading it then - (ben_tilly) - (2) - Oct. 31, 2005, 05:28:44 PM EST
                                             Ar - (Yendor) - (1) - Oct. 31, 2005, 06:45:18 PM EST
                                                 I read the first one that way, the first time - (ben_tilly) - Nov. 1, 2005, 12:03:59 AM EST
                                     E.g. - (Another Scott) - (9) - Oct. 31, 2005, 04:16:39 PM EST
                                         What I see on that page: - (admin) - (8) - Oct. 31, 2005, 04:33:47 PM EST
                                             I see. - (Another Scott) - (7) - Oct. 31, 2005, 07:25:29 PM EST
                                                 Dunno what to tell you... - (admin) - (2) - Oct. 31, 2005, 04:59:37 PM EST
                                                     www.mr-anderson.net could not be found... - (Another Scott) - (1) - Oct. 31, 2005, 05:10:10 PM EST
                                                         Can you dig it? - (pwhysall) - Oct. 31, 2005, 05:11:10 PM EST
                                                 They work here. Check your browser/adblock. -NT - (pwhysall) - Oct. 31, 2005, 05:06:27 PM EST
                                                 For some reason reading text isn't so bad. - (admin) - (2) - Oct. 31, 2005, 09:36:57 PM EST
                                                     Would you be better off wearing a patch? -NT - (broomberg) - (1) - Oct. 31, 2005, 10:15:49 PM EST
                                                         Tried that for a bit. - (admin) - Oct. 31, 2005, 10:56:45 PM EST
                             It's not just "bad vision" - (admin) - (5) - Oct. 31, 2005, 04:02:21 PM EST
                                 I'm *so* playing you at pool, for money. -NT - (pwhysall) - (4) - Oct. 31, 2005, 04:04:13 PM EST
                                     Bastard. - (admin) - (1) - Oct. 31, 2005, 04:09:40 PM EST
                                         :-D -NT - (Another Scott) - Oct. 31, 2005, 04:17:42 PM EST
                                     ICLRPD: I'm *so* playing you at pool, for money. (new thread) - (Steve Lowe) - Oct. 31, 2005, 04:14:13 PM EST
                                     You're English. Isn't that advantage enough? -NT - (ben_tilly) - Oct. 31, 2005, 05:30:02 PM EST
                             It's a pretty print problem... - (ChrisR) - (1) - Oct. 31, 2005, 05:53:56 PM EST
                                 Code Complete reserves special criticism for that one -NT - (ben_tilly) - Oct. 31, 2005, 06:31:57 PM EST

It so happens I'm half Chinese, half Cajun. There probably isn't an animal that creeps through the forest of swims in the water that's safe from me.
98 ms