Okay, now I have to post this
Sorry about the right scroll, but you need it for this one.
\nif (is_array($foonums)) { \n for($i=0;$i<count($foonums);$i++) { \n $foonum = $foonums[$i]; \n if (isByHand($foonum)) { \n $foos[$foonum] = "hand"; \n } else { \n $sql = "SELECT idnum FROM foos_transferred WHERE foonum='".$foonum."'"; \n if ($db->dbQuery($sql)) { \n $foos[$foonum] = "transferred"; \n } else { \n $sql = "SELECT idnum FROM foos_deleted WHERE foonum='".$foonum."'"; \n if ($db->dbQuery($sql)) { \n $foos[$foonum] = "deleted"; \n } else { \n $sql = "SELECT idnum FROM foos_release WHERE foonum='".$foonum."'"; \n if ($db->dbQuery($sql)) { \n $foos[$foonum] = "released"; \n } else if (substr($foonum,0,1)!='9') { \n $foos[$foonum] = "old_system"; \n } else { \n $foos[$foonum] = "alive"; \n } \n } \n } \n } \n } \n} \n \n... \n \n \nif ($conn->dbQuery($query)) { \n $success++; \n logIt('pl_foo/mainlog', $query, $o_User->username); \n#\t\t\techo "<font color='purple' size='2' face='arial'><b>QUERY: ".$query."</b></font><br>"; \n if ($conn2->dbQuery($query2)) { \n $success2++; \n logIt('pl_foo/mainlog', $query2, $o_User->username); \n#\t\t\t\techo "<font color='green' size='2' face='arial'><b>QUERY2: ".$query2."</b></font><br>"; \n if ($conn3->dbQuery($query3)) { \n $success3++; \n logIt('pl_foo/mainlog', $query3, $o_User->username); \n#\t\t\t\t\techo "<font color='magenta' size='2' face='arial'><b>QUERY3: ".$query3."</b></font><br>"; \n } else { \n logIt('pl_foo/mainlog', "FAILURE: ".$query3, $o_User->username); \n } \n } else { \n logIt('pl_foo/mainlog', "FAILURE: ".$query2, $o_User->username); \n } \n // keep going. all is well so far.\n} else {\n logIt('pl_foo/mainlog', "FAILURE: ".$query, $o_User->username);\n echo "There's an error in the loop";\n break;\n}\n\n\n...\n\n\n } else {\n logIt('pl_foo/transferlog', "DID NOT HAPPEN: ".$sql, $o_User->username);\n echo "DID NOT HAPPEN: ".$sql."
";\n }\n } else {\n logIt('pl_foo/transferlog', "FAILURE: ".$sql, $o_User->username);\n echo "FAILURE: ".$sql."
";\n }\n } else {\n logIt('pl_foo/transferlog', "FAILURE: ".$sql, $o_User->username);\n echo "FAILURE: ".$sql."
";\n }\n } else {\n logIt('pl_foo/transferlog', "FAILURE: ".$sql, $o_User->username);\n echo "FAILURE: ".$sql."
";\n }\n } else {\n logIt('pl_foo/transferlog', "FAILURE: ".$sql, $o_User->username);\n echo "FAILURE: ".$sql."
";\n }\n } else {\n logIt('pl_foo/transferlog', "FAILURE: ".$sql, $o_User->username);\n echo "FAILURE: ".$sql."
";\n }\n
Things to note:
- The clsDB->dbQuery method will return -1 on error. PHP interprets 'if( -1 )' as true.
- The last snippet has 6 different failure modes. Count the number of uniquely identifiable error and/or log messages.
- Pretty colored debugging messages.
- Actual linefeeds instead of \\n in strings.
- Using double quotes instead of single for strings that shouldn't be evaluated, then closing the quotes and concatenating the variables that could be parsed in a double-quoted string.
This isn't even the worst code from this guy.